Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhotonXGBoostEstimator : set XGBoost to use one thread to avoid spawning hundreds of OpenMP threads #45042

Merged
merged 1 commit into from
May 26, 2024
Merged

PhotonXGBoostEstimator : set XGBoost to use one thread to avoid spawning hundreds of OpenMP threads #45042

merged 1 commit into from
May 26, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 24, 2024

PR description:

Title says it all, see #44923 for details

PR validation:

Run the script #44923 (comment) and verified with gdb and info threads that the amount of threads is limited, see also #44923 (comment) and #44923 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport to be backported to 14.0.X for data-taking purposes

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone May 24, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 24, 2024

type egamma, bug-fix

@mmusich mmusich mentioned this pull request May 24, 2024
Closed
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45042/40346

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • RecoEgamma/PhotonIdentification (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@afiqaize, @varuns23, @missirol, @sameasy, @Prasant1993, @a-kapoor, @sobhatta, @Sam-Harper, @valsdav, @lgray, @jainshilpi, @ram1123 this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 24, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented May 24, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a46aa/39522/summary.html
COMMIT: 23a0326
CMSSW: CMSSW_14_1_X_2024-05-24-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45042/39522/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338839
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39718
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich changed the title [RFC]PhotonXGBoostEstimator : set XGBoost to use one thread to avoid spawning hundreds of OpenMP threads PhotonXGBoostEstimator : set XGBoost to use one thread to avoid spawning hundreds of OpenMP threads May 25, 2024
@mmusich mmusich mentioned this pull request May 25, 2024
Merged
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

francescobrivio commented May 25, 2024 •
edited
Loading

@cms-sw/orp-l2 @cms-sw/core-l2 could we merge this asap so that we can have an IB with this PR?
The backport #45043 is needed for a semi-urgent patch for HLT.

Cheers,
Francesco as ORM

@VinInn
Copy link
Contributor

VinInn commented May 26, 2024 •
edited
Loading

to be precise in the worse case on a HLT Milan machine the total number of concurrent threads spawn by openMP will be 65280
(255*256)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a50a5d7 into cms-sw:master May 26, 2024
14 checks passed
@mmusich mmusich deleted the mm_fix_44923 branch May 27, 2024 06:11
This was referenced May 27, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved egamma fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
6 participants
@mmusich @cmsbuild @mandrenguyen @francescobrivio @VinInn @antoniovilela